Skip to content
This repository has been archived by the owner on Dec 3, 2022. It is now read-only.

Fix deps #91

Merged
merged 6 commits into from
Jun 26, 2022
Merged

Fix deps #91

merged 6 commits into from
Jun 26, 2022

Conversation

Kilo59
Copy link
Owner

@Kilo59 Kilo59 commented Jun 26, 2022

Minimal fixes to dependencies and config

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 26, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.06%.

Quality metrics Before After Change
Complexity 1.84 ⭐ 2.14 ⭐ 0.30 👎
Method Length 34.35 ⭐ 35.65 ⭐ 1.30 👎
Working memory 5.03 ⭐ 5.65 ⭐ 0.62 👎
Quality 87.03% 84.97% -2.06% 👎
Other metrics Before After Change
Lines 289 279 -10
Changed files Quality Before Quality After Quality Change
blue_chip/main.py 93.56% ⭐ 93.56% ⭐ 0.00%
blue_chip/config/data.py 92.71% ⭐ 93.21% ⭐ 0.50% 👍
blue_chip/tasks/formatting.py 82.64% ⭐ 78.40% ⭐ -4.24% 👎
blue_chip/tasks/linting.py 85.57% ⭐ 82.40% ⭐ -3.17% 👎
tests/test_basic.py 88.15% ⭐ 88.15% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
blue_chip/tasks/formatting.py sort 1 ⭐ 56 ⭐ 12 😞 70.90% 🙂 Extract out complex expressions
blue_chip/tasks/formatting.py fmt 0 ⭐ 42 ⭐ 13 😞 72.58% 🙂 Extract out complex expressions
blue_chip/tasks/formatting.py fmt_only 0 ⭐ 32 ⭐ 10 😞 79.42% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Kilo59 Kilo59 marked this pull request as ready for review June 26, 2022 02:49
@Kilo59 Kilo59 merged commit e25a5ef into master Jun 26, 2022
@Kilo59 Kilo59 deleted the fix-deps branch June 26, 2022 02:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant