Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier models.csv setup #68

Merged
merged 5 commits into from
Nov 29, 2022
Merged

Easier models.csv setup #68

merged 5 commits into from
Nov 29, 2022

Conversation

Kilvoctu
Copy link
Owner

@Kilvoctu Kilvoctu commented Nov 29, 2022

This PR aims to make setting up the models.csv a little more easy

Currently a line in the csv file needs the full model name for the 2nd value. Something like this

display_name|model_full_name|activator_token    
SD 1.5|sd-v1-5-pruned-emaonly.ckpt [81761151]|

When downloading a new model and adding it to the csv, it's a little tedious because there's not a quick and easy way to know the short hash. I'd like to be able to only enter its name, like this

display_name|model_full_name|activator_token
SD 1.5|sd-v1-5-pruned-emaonly|

Some concerns:

  • It doesn't know the file extension. So if someone has "model.ckpt" and "model.safetensors", aiya will select "model.ckpt".
  • I really don't want to break all the existing models.csv that people may have. I need to find a way for both the normal way and this new way to work simultaneously.
  • I've got to make sure that the 📋 button still provides all the information correctly like before.
  • Models nested within folders need to be supported as well.
  • Probably other things I can't think of at the moment.

At some point, I'd like a better way to edit the models.csv than manually opening it up and entering fields, but I can't think of anything simple and practical.

allows putting just model name in csv (no extension or hash needed)
there are a lot of bugs to squash
use a simple index to keep track of what model is selected, regardless of full name or not
fix 🖋/🎲 buttons breaking because tuple length =/= queue object length

make some code more readable by using already defined input_tuple

give more useful info in console for buttons errors
@Kilvoctu
Copy link
Owner Author

Tested on a mixed models.csv (some full names, some short names, nested and non-nested), with many prompts. Tested buttons.
Models swapped properly each time, no other bugs that I can see..

fix 📋 not working if models.csv is on default
fix some logic issues with how i initialize variables
trim folder from model full name in the 📋 info
@Kilvoctu Kilvoctu marked this pull request as ready for review November 29, 2022 08:16
@Kilvoctu Kilvoctu merged commit e6159fa into main Nov 29, 2022
@Kilvoctu Kilvoctu deleted the simpler-model-csv branch November 29, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant