Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more parameters to πŸ–‹οΈ #81

Merged
merged 8 commits into from
Jan 7, 2023
Merged

Add more parameters to πŸ–‹οΈ #81

merged 8 commits into from
Jan 7, 2023

Conversation

Kilvoctu
Copy link
Owner

@Kilvoctu Kilvoctu commented Jan 5, 2023

This PR adds a few extra parameters to edit via the πŸ–‹οΈ modal.

This is a sorta haphazard, makeshift solution until (if) Discord provides better functionality to modals (I'd really like dropdowns in modals). The extra parameters are freehand editing, so user must ensure they're entering valid values.

The extra parameters currently are (more may be added later):

  • data model
  • steps
  • width
  • height
  • guidance scale
  • sampler
  • style
  • facefix
  • hypernetwork

To do:

  • basic error handling

A sample of how it'll look in the modal
image

expose some extra parameters for editing with πŸ–‹οΈ button

clean up some code
fix an issue in which prompt was not updating correctly with activation token when swapping model
give a message if model not found when using πŸ–‹οΈ
check each value in extended edit to be valid, and complain if it isnt
...except guidance scale and seed, for now

provide a sorta useful message for KeyError exception

move size (width/height) range to global variable
for each invalid field value provided in πŸ–‹οΈ, provide a list of valid values
@Kilvoctu
Copy link
Owner Author

Kilvoctu commented Jan 7, 2023

"basic error handling" got a bit overcomplicated.

The value for each valid field is checked (except guidance_scale for now (I'll want to do seed also)) against valid options. If user enters something wrong, AIYA will not attempt to generate an image. Instead, she's respond providing valid options to help, and allow user to try again.

Here's an example for samplers.
image

randomize seed if an invalid value is given
complain if guidance scale can't convert to float
add clip skip to πŸ–‹οΈ
optimize πŸ–‹οΈ output
guidance scale error handling in /draw
minor cleanup
clean up some code
appease pycharm
@Kilvoctu Kilvoctu marked this pull request as ready for review January 7, 2023 18:22
@Kilvoctu Kilvoctu merged commit f0a857d into main Jan 7, 2023
@Kilvoctu Kilvoctu deleted the better-pen branch January 7, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant