fix state->old may be updated incorrectly

Kimplul · Jul 25, 2022 · 95680ed · 95680ed
1 parent 162a1f6
commit 95680ed
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/hid-tmff2.c b/hid-tmff2.c
@@ -388,7 +388,7 @@ static int tmff2_upload(struct input_dev *dev,
 	state->effect = *effect;
 
 	if (old) {
-		if (test_bit(FF_EFFECT_QUEUE_UPDATE, &state->flags))
+		if (!test_bit(FF_EFFECT_QUEUE_UPDATE, &state->flags))
 			state->old = *old;
 
 		__set_bit(FF_EFFECT_QUEUE_UPDATE, &state->flags);