Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add erase_send_sync_owner to create Erased + Send + Sync references #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Zoxc
Copy link

@Zoxc Zoxc commented Nov 18, 2017

I ended up needing this when adding thread safety to rustc. I'm not sure why the IntoErased trait is unsafe, so it would be a good idea to check that I didn't break any invariants here.

@Storyyeller
Copy link
Contributor

Did you check whether Erased impls Any? That's the only potential unsafety I noticed.

@Zoxc
Copy link
Author

Zoxc commented Dec 23, 2017

@Storyyeller dyn (Erased + Sync + Send) cannot impl Any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants