Fix bug in RwLockWriteGuardRefMut #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RwLockWriteGuardRefMut` should be an `OwningRefMut` instead of an `OwningRef` as a RwLockWriteGuard can safely mutate the object it's locking
kingoflolz
added a commit
to kingoflolz/althea_rs
that referenced
this pull request
Apr 12, 2018
1. adding getter and setter methods with a trait 2. implementing the methods on Arc<RwLock<SettingsStruct>> and doing locking internally 3. return references to data instead of cloning (requires the use of owning_ref crate (which I had to fork because of bug Kimundi/owning-ref-rs#44))
|
Thanks for the contribution! Sorry for the lack of response, I had a busy year. 😬 |
jkilpatr
pushed a commit
to althea-net/rita
that referenced
this pull request
Feb 7, 2020
1. adding getter and setter methods with a trait 2. implementing the methods on Arc<RwLock<SettingsStruct>> and doing locking internally 3. return references to data instead of cloning (requires the use of owning_ref crate (which I had to fork because of bug Kimundi/owning-ref-rs#44))
jkilpatr
pushed a commit
to althea-net/rita
that referenced
this pull request
Feb 7, 2020
1. adding getter and setter methods with a trait 2. implementing the methods on Arc<RwLock<SettingsStruct>> and doing locking internally 3. return references to data instead of cloning (requires the use of owning_ref crate (which I had to fork because of bug Kimundi/owning-ref-rs#44))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
RwLockWriteGuardRefMutshould be anOwningRefMutinstead of anOwningRefas aRwLockWriteGuardcan safely mutate the object it's locking