adding support for map_with_owner #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This functionality would be helpful for "recursive" data structures represented via trees where you sometimes need to return back to the "root" from leaf nodes. |
avitex
requested changes
Oct 10, 2019
There was a problem hiding this comment.
Thanks for the PR @idubrov :)
I'd be happy to pull this feature in, I just request you the split off the fixing tests commit from this PR, and add a couple of tests.
Other than that and the spelling mistake, we are smooth sailing. Thanks again!
src/lib.rs
Outdated
| /// assert_eq!(*owning_ref, 3); | ||
| /// | ||
| /// // create a owning reference that points at the | ||
| /// // second element of the array from the owning ref that was pointig to the third |
src/lib.rs
Outdated
| /// let owning_ref = owning_ref.map(|array| &array[2]); | ||
| /// | ||
| /// // create a owning reference that points at the | ||
| /// // second element of the array from the owning ref that was pointig to the third |
Adding support for `map_with_owner` which is the same as regular `map`, but also gives a reference to the owner itself.
|
Updated; not sure what kind of tests should I write, so I just did pretty much the same test as in doctests. |
|
Thanks again 👍 The feature added is great, might just change one of the tests :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
map_with_ownerwhich is the same as regularmap, but also gives a reference to the owner itself.