Skip to content

Commit

Permalink
Memory block size reporting for UCRT 32bit fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
@KindDragon
KindDragon committed Nov 24, 2015
1 parent af90f6b commit 1ad587e
Show file tree
Hide file tree
Showing 5 changed files with 358 additions and 1,140 deletions.
Loading

4 comments on commit 1ad587e

@KindDragon
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ioannis-e Not very pretty, but it works 😄

@ioannis-e
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wellll..

I'd prefer to have a single constructor for CaptureContext. You could use the ucrt varaible like below:

CaptureContext(context_t &context, BOOL debug, void* func, BOOL ucrt = FALSE, UINT_PTR fp = (UINT_PTR)_ReturnAddress());

if i understand correctly crtdbgblockheaderucrt_t is defined the same for x86 and x64 while for crtdbgblockheader_t its different, thats why you need the ucrt variable.

but, can you explain why all those functions were removed, where they unecessary to begin with ???

@ioannis-e
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could have split the changes to two commits, to explain why the intermidiary functions were removed :)

@KindDragon
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but, can you explain why all those functions were removed, where they unecessary to begin with ???

Yes, they just call function pointer and capture context that was already captured.

Please sign in to comment.