Basic send request #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! This is looking like a great start. Once the merge conflicts are fixed I'll merge this in and probably transfer ownership to the KindyNowApp account. We'll take the conversation to Trello to discuss what's left to do. |
|
Fixed the merge conflicts - I removed the old |
|
I can't add labels on this repo, but I think this is ready for review/merge |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't complete but it's a start - 100% test coverage, for whatever that's worth. It only covers the basic send options, and only handles responses with a single nested message at the moment. We might end up removing the app setup for it, depending on whether or not we end up using any processes internally.