Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shell check warnings #242

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fix shell check warnings #242

merged 2 commits into from
Oct 9, 2023

Conversation

S0AndS0
Copy link
Contributor

@S0AndS0 S0AndS0 commented Oct 6, 2023

Description of changes

  • SC2002 -- piping cat through two grep calls may instead be handled all by one grep call within both the GitHub Action configuration, and build script.

    Note; I recognize above described change is totally a micro optimization, but it also reduces shellcheck noise and shouldn't break anything

  • SC2086 -- double quoting prevents unintentional word splitting were one to call script with TIMESTAMP defined, ex TIMESTAMP="questionable idea" ./bin/build.sh

Related documentation

GitHub Action

@ReFil
Copy link
Collaborator

ReFil commented Oct 9, 2023

LGTM, Thanks for this!

@ReFil ReFil merged commit 8e2e77b into KinesisCorporation:V3.0 Oct 9, 2023
1 check passed
sanderdrummer added a commit to sanderdrummer/Adv360-Pro-ZMK that referenced this pull request Oct 19, 2023
@sanderdrummer @x418
@ReFil @S0AndS0
Update (#5)
090be1e 
* Add instructions for upgrading from V2 to V3 in README (KinesisCorporation#197)

This commit adds a new section in the README.md file detailing instructions for users upgrading from V2 to V3.

* Add CHANGELOG (KinesisCorporation#221)

* Readme rewrite (KinesisCorporation#222)

* Fix shell check warnings (KinesisCorporation#242)

* Fix SC2002 Shell Check warning

* Fix SC2086 Shell Check warnings

* Further documentation work (KinesisCorporation#241)

* Minor cleanup, change date format, add beta testing

* Update CHANGELOG.md

* feat: update keymap

---------

Co-authored-by: Santhosh Kannan <santhoshknn@gmail.com>
Co-authored-by: ReFil <31960031+ReFil@users.noreply.github.com>
Co-authored-by: S0AndS0 <strangerthanbland@gmail.com>
clayne11 pushed a commit to clayne11/Adv360-Pro-ZMK that referenced this pull request Nov 18, 2023
@S0AndS0 @clayne11
Fix shell check warnings (KinesisCorporation#242)
c927e97 
* Fix SC2002 Shell Check warning

* Fix SC2086 Shell Check warnings
Shamasher pushed a commit to Shamasher/Adv360-Pro-ZMK-fork that referenced this pull request Nov 22, 2023
@S0AndS0 @Shamasher
Fix shell check warnings (KinesisCorporation#242)
6d09097 
* Fix SC2002 Shell Check warning

* Fix SC2086 Shell Check warnings
Coobaha added a commit to Coobaha/Adv360-Pro-ZMK that referenced this pull request Nov 26, 2023
@Coobaha
Merge remote-tracking branch 'upstream/V3.0' into v3.0
5312c3a 
* upstream/V3.0:
  Revert "Add version macro to keymap.json (KinesisCorporation#269)"
  Add version macro to keymap.json (KinesisCorporation#269)
  Changelog new base ZMK update (KinesisCorporation#268)
  Version compiled FW with automatic macro (KinesisCorporation#267)
  Document new NKRO settings (KinesisCorporation#264)
  Improve documentation based on feedback (KinesisCorporation#260)
  Update reset file
  Update ZMK (KinesisCorporation#248)
  Further documentation work (KinesisCorporation#241)
  Fix shell check warnings (KinesisCorporation#242)
  Readme rewrite (KinesisCorporation#222)
  Add CHANGELOG (KinesisCorporation#221)

# Conflicts:
#	Makefile
#	config/adv360.keymap
asmodeus812 pushed a commit to asmodeus812/Adv360-Pro that referenced this pull request Dec 6, 2023
@S0AndS0 @asmodeus812
Fix shell check warnings (KinesisCorporation#242)
48c5021 
* Fix SC2002 Shell Check warning

* Fix SC2086 Shell Check warnings
alok added a commit to alok/Adv360-Pro-ZMK that referenced this pull request Dec 6, 2023
@alok
Merge remote-tracking branch 'upstream/V3.0'
baf0175 
* upstream/V3.0:
  Update bluetooth settings in light of user feedback (KinesisCorporation#289)
  Revert "Add version macro to keymap.json (KinesisCorporation#269)"
  Add version macro to keymap.json (KinesisCorporation#269)
  Changelog new base ZMK update (KinesisCorporation#268)
  Version compiled FW with automatic macro (KinesisCorporation#267)
  Document new NKRO settings (KinesisCorporation#264)
  Improve documentation based on feedback (KinesisCorporation#260)
  Update reset file
  Update ZMK (KinesisCorporation#248)
  Further documentation work (KinesisCorporation#241)
  Fix shell check warnings (KinesisCorporation#242)
  Readme rewrite (KinesisCorporation#222)
  Add CHANGELOG (KinesisCorporation#221)
noseworthy pushed a commit to noseworthy/Adv360-Pro-ZMK that referenced this pull request Jan 16, 2024
@S0AndS0 @noseworthy
Fix shell check warnings (KinesisCorporation#242)
3456e5f 
* Fix SC2002 Shell Check warning

* Fix SC2086 Shell Check warnings
zemackdaddy pushed a commit to zemackdaddy/Adv360-Pro-ZMK that referenced this pull request Jan 22, 2024
@S0AndS0
Fix shell check warnings (KinesisCorporation#242)
5877b84 
* Fix SC2002 Shell Check warning

* Fix SC2086 Shell Check warnings
tricktux pushed a commit to tricktux/Adv360-Pro-ZMK that referenced this pull request Feb 10, 2024
@S0AndS0 @tricktux
Fix shell check warnings (KinesisCorporation#242)
f6c3064 
* Fix SC2002 Shell Check warning

* Fix SC2086 Shell Check warnings
ztomer pushed a commit to ztomer/Adv360-Pro-ZMK that referenced this pull request Apr 16, 2024
@S0AndS0 @ztomer
Fix shell check warnings (KinesisCorporation#242)
14d3f96 
* Fix SC2002 Shell Check warning

* Fix SC2086 Shell Check warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@S0AndS0 @ReFil