Elixir: Padlock verification is case-insensitive #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halostatue
added
bug
halostatue
force-pushed
the
handle-lowercase-padlocks
branch
from
6853440
to
8b21ed7
Compare
ohnit
approved these changes
Sep 5, 2023
mikestok
approved these changes
Sep 5, 2023
halostatue
force-pushed
the
handle-lowercase-padlocks
branch
from
8b21ed7
to
d38823f
Compare
Resolved an issue where padlock values sent using lowercase hex values were not comparing properly. Added tests for the case as well as an additional validation doctest. A later update will add this to the integration test suite as a variable. Signed-off-by: Austin Ziegler <aziegler@kineticcommerce.com>
halostatue
force-pushed
the
handle-lowercase-padlocks
branch
from
d38823f
to
6b787d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved an issue where padlock values sent using lowercase hex values were not comparing properly. Added tests for the case as well as an additional validation doctest.
A later update will add this to the integration test suite as a variable.