Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic memory allocation #6

Open
RolfSander opened this issue Oct 1, 2021 · 1 comment
Open

dynamic memory allocation #6

RolfSander opened this issue Oct 1, 2021 · 1 comment
Labels
code / structural Related to structural source code updates feature New feature or request future development Items that will be worked on in the future
Milestone
4.0.0

Comments

@RolfSander
Copy link
Contributor

A lot of values need to be increased in gdata.h and elsewhere (e.g., MAX_EQN) when the chemical mechanism becomes too large. It would be great if KPP would use dynamic memory allocation depending on the size of the chemical mechanism. This is probably a big task, and I don't think I will be able to do it. However, I've created this issue so we can discuss this.
@RolfSander RolfSander added the feature New feature or request label Oct 1, 2021
@RolfSander
Copy link
Contributor Author

Thinking about this feature again, I fear that it won't be possible in C. For the time being, I guess we'll have to recompile KPP every time we reach one of the limits.

I've added the milestone 4.0.0 to this issue.

@RolfSander RolfSander added this to the 4.0.0 milestone Jun 28, 2022
yantosca added a commit to geoschem/geos-chem that referenced this issue Oct 18, 2022
@yantosca
Bug fix: Make sure FIX is the 2nd arg to Fun in gckpp_Integrator.F90
63e3fa2 
KPP/carboncycle/gckpp_Integrator.F90
- Added a kludge: In routine FunTemplate, we now pass FIX (and not VAR)
  as the 2nd argument to Fun.  This error was causing the F variable
  within Fun to be corrupted, which was propagating negatives through
  the code.
- NOTE: We have patched this file for KPP 2.5.0, but a final fix will
  be issued in KPP 3.0.0.  We will eventually rebuild all mechanisms
  with KPP 3.0.0 anyway.
- See KineticPreProcessor/KPP#6 for more info.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@RolfSander RolfSander mentioned this issue Jan 16, 2023
Merged
@yantosca yantosca added code / structural Related to structural source code updates future development Items that will be worked on in the future labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code / structural Related to structural source code updates feature New feature or request future development Items that will be worked on in the future
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@yantosca @RolfSander