Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 34: Create multiple characters in a row #44

Merged
merged 3 commits into from Oct 14, 2019

Conversation

@Cadesh
Copy link
Contributor

Cadesh commented Oct 12, 2019

Description of pull request

Hello @KingFruit85, I solved this issue with a loop that checks the command lines arguments, when it founds the argument '-n' it checks if the next argument is a number and uses it as the number of characters to be created. This loop can be expanded later to check race, class, etc.
Use the program as (to create 3 characters): node core.js -n 3

Resolves #34

Has it been tested?

  • Yes
  • No
  • Testing not needed
Copy link
Owner

KingFruit85 left a comment

@Cadesh Hey this is great! Happy for you to merge 😊

EDIT: after waking up a bit and reviewing I have a few questions about the code, for my learning if anything else. Please see review comments.

Copy link
Owner

KingFruit85 left a comment

Please see comments

core.js Show resolved Hide resolved
core.js Show resolved Hide resolved
@KingFruit85

This comment has been minimized.

Copy link
Owner

KingFruit85 commented Oct 13, 2019

happy for you to do the honors @Cadesh

@KingFruit85 KingFruit85 merged commit 0e6775f into KingFruit85:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.