Issue 34: Create multiple characters in a row #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingFruit85
approved these changes
Oct 13, 2019
There was a problem hiding this comment.
@Cadesh Hey this is great! Happy for you to merge 😊
EDIT: after waking up a bit and reviewing I have a few questions about the code, for my learning if anything else. Please see review comments.
KingFruit85
requested changes
Oct 13, 2019
KingFruit85
approved these changes
Oct 13, 2019
|
happy for you to do the honors @Cadesh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of pull request
Hello @KingFruit85, I solved this issue with a loop that checks the command lines arguments, when it founds the argument '-n' it checks if the next argument is a number and uses it as the number of characters to be created. This loop can be expanded later to check race, class, etc.
Use the program as (to create 3 characters): node core.js -n 3
Resolves #34
Has it been tested?