Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min() and max() expression functions. #149

Merged
merged 4 commits into from May 3, 2019
Merged

Add min() and max() expression functions. #149

merged 4 commits into from May 3, 2019

Conversation

Prof9
Copy link
Contributor

@Prof9 Prof9 commented Apr 25, 2019

This adds min() and max() expression functions which take any number (min 1) of int or float parameters. The result type is int if all parameters are int, otherwise the parameters are converted to float and the result type is also float.

One potential use case would be to get the maximum size of a number of files so you could allocate a buffer that is just large enough to hold any of those files.

@Kingcom
Copy link
Owner

Kingcom commented May 3, 2019

Could you add a small test for these functions? Looks good otherwise.

@Kingcom Kingcom merged commit 8de6978 into Kingcom:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants