feat: added light theme #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
baiwusanyu-c
commented
Jun 26, 2023
baiwusanyu-c
commented
|
If |
Sight-wcg
reviewed
Jun 26, 2023
|
@baiwusanyu-c 不好意思，我只是在关注这个项目，并非维护者。 |
我知道，但依旧感谢你的帮助 |
sxzz
reviewed
Jun 27, 2023
src/themes/index.ts
Outdated
| return themeName; | ||
| export async function loadTheme( | ||
| editor: typeof import('monaco-editor-core').editor, | ||
| dark = true) { |
There was a problem hiding this comment.
Is this param really necessary? How about returning an object
{ dark: 'vs-code-theme-converted-dark', light: 'vs-code-theme-converted-light' }
There was a problem hiding this comment.
Of course can do this, then you need to judge whether to use light or dark when using it in the downstream repo
There was a problem hiding this comment.
Yes. Cuz we only need to execute loadTheme once so that we cannot get dark and light for one execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.