Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default AllowDrop setting for TreeViewItem #170

Closed
stevemonaco opened this issue Sep 11, 2020 · 2 comments
Closed

Default AllowDrop setting for TreeViewItem #170

stevemonaco opened this issue Sep 11, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@stevemonaco
Copy link

Hi, I recently ported one of my applications from MahApps to ModernWPF and had some troubles with previously working drag+drop behavior breaking for a TreeView using GongSolutions.WPF.DragDrop. I tested a standalone program with vanilla WPF vs ModernWPF and vanilla WPF TreeView worked out-of-the-box with GongSolutions whereas ModernWPF did not.

I continued to test ModernWPF by adding padding around the TreeView and the padding area supported drag+drop, but the nodes still did not. Finally, I looked through DefaultTreeViewItemStyle and discovered that AllowDrop was set to False. This was easily fixed on my end by creating a new style. I still suggest changing DefaultTreeViewItemStyle's AllowDrop setting to True to keep vanilla WPF behavior if this wasn't done intentionally for perf reasons. Thanks.

@Kinnara
Copy link
Owner

Kinnara commented Sep 13, 2020

Thanks for bringing this up. That AllowDrop setter was merely carried over from the corresponding WinUI style, and should be removed as you said.

@Kinnara Kinnara added the bug Something isn't working label Sep 13, 2020
@Kinnara Kinnara self-assigned this Sep 13, 2020
Kinnara added a commit that referenced this issue Sep 15, 2020
@Kinnara
Copy link
Owner

Kinnara commented Sep 23, 2020

Resolved by cba42fb.

@Kinnara Kinnara closed this as completed Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants