-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic support for IconSource and its subclasses #192
Conversation
Should I also add the xml documentation comments? |
Hey @Kinnara, I explored ModernWpf's source code. This increases the inconsistency in code between WinUI and ModernWpf. What I suggest you is to take a look at our toolkit and see how it handles this scenario. I've made a This will help us to reduce extra code and increase the consistency between the codebases. My workaround is imperfect but with your help, we can improve it. What do you say? |
and moved code into an existing file to resolved CS0436 warning
@Kinnara, all done! This PR is ready to be merged. |
The main road block is that we have to call |
We have to unregister the callbacks when unloading the control. https://stackoverflow.com/a/45160026 This behaviour is same in WinRT, isn't it. I've a little experience porting Controls from WCT so I can confirm they do the callbacks unregistering on unload. If you say so, it must correct be correct 🤷♂️. Thanks for merging this PR! |
Added basic support for IconSource and its subclasses (Kinnara#192) * Ported IconSource and its sub classes from WinUI * Resolved suggestions * Added headers with copyright & license notices to avoid potential licensing issues * Removed an unnecessary duplicate class and moved code into an existing file to resolved CS0436 warning Co-authored-by: Yimeng Wu <me@kinnara.cn>
* Ported IconSource and its sub classes from WinUI * Resolved suggestions * Added headers with copyright & license notices to avoid potential licensing issues * Removed an unnecessary duplicate class and moved code into an existing file to resolved CS0436 warning
Fixes #191