Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make structures Errors more informative. #12

Open
NavidMitchell opened this issue Nov 6, 2023 · 0 comments
Open

Make structures Errors more informative. #12

NavidMitchell opened this issue Nov 6, 2023 · 0 comments

Comments

@NavidMitchell
Copy link
Contributor

Currently there are many structures errors that are not very intuitive. I am capturing them here so we can return more intuitive errors to the client.

Current Error: All shards failed.
Should Indicate: There was a problem with the search or query string passed to structures.

2023-11-05 20:38:36 co.elastic.clients.elasticsearch._types.ElasticsearchException: [es/search] failed: [search_phase_execution_exception] all shards failed

Current Error: Id field cannot be null or blank.
Should indicate: That data passed to a save or update operation has a null id field. Additional information to help determine what data is missing the id, so this can be more easily handled during bulk operations.

2023-11-05 20:53:40 java.lang.IllegalArgumentException: Id field cannot be null or blank
2023-11-05 20:53:40     at org.kinotic.structures.internal.api.decorators.instances.IdDecoratorInstance.process(IdDecoratorInstance.java:28) ~[structures-core-1.8.8-SNAPSHOT.jar:na]
2023-11-05 20:53:40     at org.kinotic.structures.internal.api.decorators.instances.IdDecoratorInstance.process(IdDecoratorInstance.java:12) ~[structures-core-1.8.8-SNAPSHOT.jar:na]
2023-11-05 20:53:40     at org.kinotic.structures.internal.api.decorators.RawJsonUpsertPreProcessor.doProcess(RawJsonUpsertPreProcessor.java:93) ~[structures-core-1.8.8-SNAPSHOT.jar:na]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant