Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毀Remove Assert Extensions #303

Closed
7 tasks done
CalvinWilkinson opened this issue Oct 24, 2023 · 1 comment 路 Fixed by #323
Closed
7 tasks done

馃毀Remove Assert Extensions #303

CalvinWilkinson opened this issue Oct 24, 2023 · 1 comment 路 Fixed by #323
Assignees
Labels
low-priority Low Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Oct 24, 2023

Complete The Item Below

  • I have updated the title without removing the 馃毀 emoji.

Description

Replace all AssertExtensions uses across the code base and then delete the AssertExtensions file.

Reason:
Over many months, all of the assertion code across the codebase has been getting refactored to use the FluentAssertions library API. This has greatly improved the assertion code which has made the extension methods provided by the AssertExtensions class not required anymore.

Note
Most of the uses of the extensions methods will probably be replaced just by completing the rest
of the issues for refactoring assertion code. These issues are listed in the list of issue dependencies below.
Please complete the issue dependencies below first before starting this issue.

Acceptance Criteria

  • All uses of the AssertExtensions extensions methods replaced with FluentAssertion or standard XUnit code
  • The AssertExtensions file has been deleted from the code base.

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct milestone (if applicable).

Issue Dependencies

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 馃悰bug
Breaking Changes 馃Жbreaking changes
New Feature 鉁╪ew feature
CICD Changes 鈾伙笍cicd
Config Changes 鈿欙笍config
Performance Improvements 馃弾锔弍erformance
Code Doc Changes 馃棐锔廳ocumentation/code
Product Doc Changes 馃摑documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added tech-debt Code refactoring or cleanup / tech debt reduction low-priority Low Priority preview Done while in preview labels Oct 24, 2023
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.17 milestone Oct 24, 2023
@thestbar
Copy link
Contributor

Could you please assign this task to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-priority Low Priority preview Done while in preview tech-debt Code refactoring or cleanup / tech debt reduction
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants