Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Refactor unit test assertions #106

Closed
13 tasks done
kselena opened this issue Sep 9, 2022 · 2 comments · Fixed by #301
Closed
13 tasks done

🚧Refactor unit test assertions #106

kselena opened this issue Sep 9, 2022 · 2 comments · Fixed by #301
Assignees
Labels
good-first-issue Good for newcomers 🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! medium-priority Medium Priority tech-debt Code refactoring or cleanup / tech debt reduction

Comments

@kselena
Copy link
Member

kselena commented Sep 9, 2022

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Refactor all of the unit test assertions to use the FluentAssertions library.
This will greatly cleanup the unit testing side of things and make the creation of unit tests easier.

Note

  1. We have been migrating all of our assertion code for the past 6 months from standard XUnit assertions API to FluentAssertions API API. Most of the code base has been converted and examples can be found all of the place. Please don't hesitate to ask questions and for help if needed.
  2. Please follow our Contribution Guide
  3. Join the KinsonDigital Community!!

Acceptance Criteria

  • Latest version of FluentAssertions Nuget package added to the project
  • Refactor the files below:
    • AudioDeviceManagerNotInitializedExceptionTests.cs - 000 lines
    • InitializeDeviceExceptionTests.cs - 50 lines
    • AudioDeviceManagerTests.cs - 60 lines
    • AudioExceptionTests.cs - 509 lines
    • LoadLibraryExceptionTests.cs - 50 lines

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct project (if required).
  • Issue linked to the correct milestone (if required).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
Workflow Changes workflow
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@kselena kselena added tech-debt Code refactoring or cleanup / tech debt reduction medium-priority Medium Priority labels Sep 9, 2022
@SyedMSawaid
Copy link

Kindly assign me this task.

And I think you didn't mentioned number of lines on AudioDeviceManagerNotInitializedExceptionTests.cs

@SyedMSawaid SyedMSawaid removed their assignment Nov 8, 2022
@CalvinWilkinson CalvinWilkinson added the good-first-issue Good for newcomers label May 8, 2023
@CalvinWilkinson CalvinWilkinson removed their assignment May 8, 2023
@CalvinWilkinson CalvinWilkinson added the 🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! label Oct 2, 2023
@thestbar
Copy link
Contributor

@CalvinWilkinson I would like to work on this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers 🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! medium-priority Medium Priority tech-debt Code refactoring or cleanup / tech debt reduction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants