Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毀Change owner and repos name setup #15

Closed
9 tasks done
CalvinWilkinson opened this issue Sep 24, 2022 · 1 comment 路 Fixed by #16
Closed
9 tasks done

馃毀Change owner and repos name setup #15

CalvinWilkinson opened this issue Sep 24, 2022 · 1 comment 路 Fixed by #16
Assignees
Labels
high priority High Priority 鉁╪ew feature New feature that does not exist preview Done while in preview

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Sep 24, 2022

Complete The Item Below

  • I have updated the title without removing the 馃毀 emoji.

Description

Convert the 'Owner' and 'MainProjNamefields to private properties that are marked as a NUKE[Parameter]. Refactor the name of the 'Owner field (which is being converted into a prop) to RepoOwner.
Refactor the name of the MainProjName field (which is being converted into a prop) to RepoName.

Also, add the correct parameters and values in the ~/.nuke/parametes.json file like below.

{
  "$schema": "./build.schema.json",
  "Solution": "CICD.sln",
  "RepoOwner": "KinsonDigital",
  "RepoName": "CICD"
}

Acceptance Criteria

  • Refactor the Owner field name to RepoOwner and refactor to a private property
  • Refactor the MainProjName field name to RepoName and refactor to a private property

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct project (if applicable).
  • Issue linked to the correct milestone (if applicable).
  • Draft pull request created and linked to this issue (only required with code changes).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 馃悰bug
Breaking Changes 馃Жbreaking changes
New Feature 鉁╪ew feature
Workflow Changes workflow
Code Doc Changes 馃棐锔廳ocumentation/code
Product Doc Changes 馃摑documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added high priority High Priority preview Done while in preview 鉁╪ew feature New feature that does not exist labels Sep 24, 2022
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.4 milestone Sep 24, 2022
@CalvinWilkinson CalvinWilkinson self-assigned this Sep 24, 2022
CalvinWilkinson added a commit that referenced this issue Sep 24, 2022
@CalvinWilkinson CalvinWilkinson linked a pull request Sep 24, 2022 that will close this issue
12 tasks
@CalvinWilkinson
Copy link
Member Author

CalvinWilkinson commented Sep 25, 2022

This is set to 鉁╪ew feature New feature that does not exist because it is allowing the ability to externally set the RepoOwner, RepoName and ProjectName externally in the .nuke/parameters.json file. This allows other projects to choose what those values are and makes the build system more flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority High Priority 鉁╪ew feature New feature that does not exist preview Done while in preview
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant