🚧Improve GitHubClient setup and usage

[CalvinWilkinson]

Complete The Item Below

• I have updated the title without removing the 🚧 emoji.

Description

Improve the GitHubClient setup and usage throughout the project.

Currently, the setup of the GitHubClient is not ideal when trying to make authorized GitHub API requests when running targets that use the GitHub API. To try and solve this issue, the LoadSecrestService was created to load a token to be used for setting up the GitHubClient for authorized requests. This needs to be put into use.

Create a new service called GitHubClientService that is used to create a GitHubClient object that is set up with a token for authorized requests. The new GitHubClientService will inject and use the LoadSecretsService to load the token from the disk.

The GitHubClientService and LoadSecretsService should also be set up with SimpleInjector so they can be easily consumed. The GitHubClientService should be set up in the IoC container as a singleton.

The GitHubClient property will be a readonly property that uses the GitHubClientService every time it is requested. The service will lazy load/create the internal client object/field. Every subsequent request into the service will check if the field is null and if it is not, simply return a reference of the field.

Acceptance Criteria

• LoadSecretsService changes
  • Create an interface for the service for setup for the IoC container
  • Refactor the main implementation code to be able to use System.IO.Abstractions
  • Create unit tests for the LoadSecretsService class
• Create new GitHubClientService service
• Convert the GitHubClient from a private static field to a private property with a getter
  • The getter will call out to the GitHubClientService service to get the client
• LoadSecretsService name refactored to SecretService
  • Refactor all var and param names to appropriate names
• If the loaded secret is null or empty, throw an exception

ToDo Items

• Change type labels added to this issue. Refer to the Change Type Labels section below.
• Priority label added to this issue. Refer to the Priority Type Labels section below.
• Issue linked to the correct project (if applicable).
• Issue linked to the correct milestone (if applicable).
• Draft pull request created and linked to this issue (only required with code changes).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type	Label
Bug Fixes	🐛bug
Breaking Changes	🧨breaking changes
New Feature	✨new feature
Workflow Changes	workflow
Code Doc Changes	🗒️documentation/code
Product Doc Changes	📝documentation/product

Priority Type Labels

Priority Type	Label
Low Priority	low priority
Medium Priority	medium priority
High Priority	high priority

Code of Conduct

• I agree to follow this project's Code of Conduct.