Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毀Refactor classes to internal and/or sealed #26

Closed
9 tasks done
CalvinWilkinson opened this issue Sep 27, 2022 · 0 comments 路 Fixed by #30
Closed
9 tasks done

馃毀Refactor classes to internal and/or sealed #26

CalvinWilkinson opened this issue Sep 27, 2022 · 0 comments 路 Fixed by #30
Assignees
Labels
馃Жbreaking changes Feature/changes contains breaking changes low priority Low Priority preview Done while in preview tech debt Code refactoring or cleanup / tech debt reduction

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Sep 27, 2022

Complete The Item Below

  • I have updated the title without removing the 馃毀 emoji.

Description

This is a build tool. Not a library meant for anybody to use to solve build problems. It is currently only for the KinsonDigital organization. Due to this, the code should be more hidden and closed off.

If the need arises in the future to expose or unseal anything for extension, it can be done then.

If the class can be internal, make it internal.
All classes should be sealed unless any inheritance is going on. But I do not think that is going on.

Acceptance Criteria

  • All classes that should be internal, is set to internal
  • All classes that are not sealed should be set to sealed.

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct project (if applicable).
  • Issue linked to the correct milestone (if applicable).
  • Draft pull request created and linked to this issue (only required with code changes).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 馃悰bug
Breaking Changes 馃Жbreaking changes
New Feature 鉁╪ew feature
Workflow Changes workflow
Code Doc Changes 馃棐锔廳ocumentation/code
Product Doc Changes 馃摑documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added the low priority Low Priority label Sep 27, 2022
@CalvinWilkinson CalvinWilkinson self-assigned this Sep 27, 2022
CalvinWilkinson added a commit that referenced this issue Sep 28, 2022
@CalvinWilkinson CalvinWilkinson added preview Done while in preview tech debt Code refactoring or cleanup / tech debt reduction labels Sep 28, 2022
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.5 milestone Sep 28, 2022
@CalvinWilkinson CalvinWilkinson linked a pull request Sep 28, 2022 that will close this issue
12 tasks
@CalvinWilkinson CalvinWilkinson added the 馃Жbreaking changes Feature/changes contains breaking changes label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃Жbreaking changes Feature/changes contains breaking changes low priority Low Priority preview Done while in preview tech debt Code refactoring or cleanup / tech debt reduction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant