Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毀Handle GitHubActionsService issue #42

Closed
8 tasks done
CalvinWilkinson opened this issue Sep 29, 2022 · 0 comments 路 Fixed by #44
Closed
8 tasks done

馃毀Handle GitHubActionsService issue #42

CalvinWilkinson opened this issue Sep 29, 2022 · 0 comments 路 Fixed by #44
Assignees
Labels
馃悰bug Something isn't working high priority High Priority preview Done while in preview

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Sep 29, 2022

Complete The Item Below

  • I have updated the title without removing the 馃毀 emoji.

Description

An error is thrown when trying to get the pull request number for a target when the run is not a pull request run.

Here is the link to the CICDTest to the 馃Debuggin Workflow run of when the error occurred.

Error Screenshot:
image


More Information:
In the GitHubActionsService class, the PullRequestNumber property gets the pull request number from either the pull request number value sent in via the CLI during local builds or from the GitHubActions.Instance.PullRequestNumber property during server builds.

The problem is when running a server run that is not a pull request. For example, manual execution using the workflow_dispatch event. Because the run is not a pull request run, their is no pull request data available. Internally in the property, NUKE is using JObject to get the pull request data from some JSON data. But since that data is not available, it explodes. 馃挜

To fix this, make a change in the GitHubActionsService.PullRequestNumber property. Just first check to see if the build is a server build. If so, use the GitHubActions.Instance.PullRequestNumber value. If not, return null.

Acceptance Criteria

  • Bug fixed

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct project (if applicable).
  • Issue linked to the correct milestone (if applicable).
  • Draft pull request created and linked to this issue (only required with code changes).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 馃悰bug
Breaking Changes 馃Жbreaking changes
New Feature 鉁╪ew feature
Workflow Changes workflow
Code Doc Changes 馃棐锔廳ocumentation/code
Product Doc Changes 馃摑documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added high priority High Priority preview Done while in preview 馃悰bug Something isn't working labels Sep 29, 2022
@CalvinWilkinson CalvinWilkinson self-assigned this Sep 29, 2022
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.7 milestone Sep 29, 2022
CalvinWilkinson added a commit that referenced this issue Sep 30, 2022
@CalvinWilkinson CalvinWilkinson linked a pull request Sep 30, 2022 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰bug Something isn't working high priority High Priority preview Done while in preview
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant