You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have updated the title without removing the 馃毀 emoji.
Description
An error is thrown when trying to get the pull request number for a target when the run is not a pull request run.
Here is the link to the CICDTest to the 馃Debuggin Workflow run of when the error occurred.
Error Screenshot:
More Information:
In the GitHubActionsService class, the PullRequestNumber property gets the pull request number from either the pull request number value sent in via the CLI during local builds or from the GitHubActions.Instance.PullRequestNumber property during server builds.
The problem is when running a server run that is not a pull request. For example, manual execution using the workflow_dispatch event. Because the run is not a pull request run, their is no pull request data available. Internally in the property, NUKE is using JObject to get the pull request data from some JSON data. But since that data is not available, it explodes. 馃挜
To fix this, make a change in the GitHubActionsService.PullRequestNumber property. Just first check to see if the build is a server build. If so, use the GitHubActions.Instance.PullRequestNumber value. If not, return null.
Acceptance Criteria
Bug fixed
ToDo Items
Change type labels added to this issue. Refer to the Change Type Labels section below.
Priority label added to this issue. Refer to the Priority Type Labels section below.
Issue linked to the correct project (if applicable).
Issue linked to the correct milestone (if applicable).
Draft pull request created and linked to this issue (only required with code changes).
Issue Dependencies
No response
Related Work
No response
Additional Information:
Change Type Labels
Change Type
Label
Bug Fixes
馃悰bug
Breaking Changes
馃Жbreaking changes
New Feature
鉁╪ew feature
Workflow Changes
workflow
Code Doc Changes
馃棐锔廳ocumentation/code
Product Doc Changes
馃摑documentation/product
Priority Type Labels
Priority Type
Label
Low Priority
low priority
Medium Priority
medium priority
High Priority
high priority
Code of Conduct
I agree to follow this project's Code of Conduct.
The text was updated successfully, but these errors were encountered:
Complete The Item Below
Description
An error is thrown when trying to get the pull request number for a target when the run is not a pull request run.
Here is the link to the CICDTest to the
馃Debuggin Workflow
run of when the error occurred.Error Screenshot:
More Information:
In the
GitHubActionsService
class, thePullRequestNumber
property gets the pull request number from either the pull request number value sent in via the CLI during local builds or from theGitHubActions.Instance.PullRequestNumber
property during server builds.The problem is when running a server run that is not a pull request. For example, manual execution using the
workflow_dispatch
event. Because the run is not a pull request run, their is no pull request data available. Internally in the property, NUKE is usingJObject
to get the pull request data from some JSON data. But since that data is not available, it explodes. 馃挜To fix this, make a change in the
GitHubActionsService.PullRequestNumber
property. Just first check to see if the build is a server build. If so, use theGitHubActions.Instance.PullRequestNumber
value. If not, return null.Acceptance Criteria
ToDo Items
Issue Dependencies
No response
Related Work
No response
Additional Information:
Change Type Labels
馃悰bug
馃Жbreaking changes
鉁╪ew feature
workflow
馃棐锔廳ocumentation/code
馃摑documentation/product
Priority Type Labels
low priority
medium priority
high priority
Code of Conduct
The text was updated successfully, but these errors were encountered: