Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毀Issue with detecting open milestone pull requests #67

Closed
9 tasks done
CalvinWilkinson opened this issue Oct 7, 2022 · 0 comments 路 Fixed by #68
Closed
9 tasks done

馃毀Issue with detecting open milestone pull requests #67

CalvinWilkinson opened this issue Oct 7, 2022 · 0 comments 路 Fixed by #68
Assignees
Labels
馃悰bug Something isn't working high priority High Priority preview Done while in preview

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Oct 7, 2022

Complete The Item Below

  • I have updated the title without removing the 馃毀 emoji.

Description

When detecting open pull requests in a milestone and when the detection should skip release todo issues & pull requests, the issue or pull request is detected anyways when it should not. This is a simple fix. The boolean value and comparison logic should be changed to the setup below.

ThatAllOfTheReleaseMilestoneIssuesAreClosed() Requirement Method:

        var openMilestoneIssues = GitHubClient.Issue.IssuesForMilestone(RepoOwner, RepoName, projectVersion)
            .Result
-            .Where(i => (skipReleaseToDoIssues || i.IsReleaseToDoIssue(releaseType)) && i.State == ItemState.Open).ToArray();
+            .Where(i => (skipReleaseToDoIssues is false && i.IsReleaseToDoIssue(releaseType)) && i.State == ItemState.Open).ToArray();

ThatAllOfTheReleaseMilestonePullRequestsAreClosed() Requirement Method:

        var openMilestonePullRequests = GitHubClient.Issue.PullRequestsForMilestone(RepoOwner, RepoName, $"v{projectVersion}")
            .Result
-            .Where(i => (skipReleaseToDoPullRequests || i.IsReleasePullRequest(releaseType)) && i.State == ItemState.Open).ToArray();
+            .Where(i => (skipReleaseToDoPullRequests is false && i.IsReleasePullRequest(releaseType)) && i.State == ItemState.Open).ToArray();

Acceptance Criteria

  • ThatAllOfTheReleaseMilestoneIssuesAreClosed() requirement method fixed
  • ThatAllOfTheReleaseMilestonePullRequestsAreClosed() requirement method fixed

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct project (if applicable).
  • Issue linked to the correct milestone (if applicable).
  • Draft pull request created and linked to this issue (only required with code changes).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 馃悰bug
Breaking Changes 馃Жbreaking changes
New Feature 鉁╪ew feature
Workflow Changes workflow
Code Doc Changes 馃棐锔廳ocumentation/code
Product Doc Changes 馃摑documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added high priority High Priority preview Done while in preview 馃悰bug Something isn't working labels Oct 7, 2022
@CalvinWilkinson CalvinWilkinson self-assigned this Oct 7, 2022
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.9 milestone Oct 7, 2022
CalvinWilkinson added a commit that referenced this issue Oct 7, 2022
@CalvinWilkinson CalvinWilkinson linked a pull request Oct 7, 2022 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰bug Something isn't working high priority High Priority preview Done while in preview
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant