Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Add new funcs to release client #66

Merged
merged 11 commits into from
May 15, 2024

Conversation

CalvinWilkinson
Copy link
Member

@CalvinWilkinson CalvinWilkinson commented May 15, 2024

Description:

To allow this pull request to be merged, please make sure that the following items of this pull request are complete.

This pull request closes #65

✅The pull request head branch must be a feature branch with the syntax 'feature/-sync-testing'.
✅The pull request base branch must be a 'main' or 'preview' branch..
✅The pull request head branch contains a valid issue number.
✅The pull request title matches the linked issue title exactly.
✅The pull request assignees match the assignees of the issue.
✅The pull request labels match the labels of the issue.
✅The pull request organizational projects match the organizational projects of the issue.
✅The pull requests milestone matches the milestone of the issue.


Additional Info:

  1. Pull requests are automatically synced with the associated issue upon creation by one of the KinsonDigital workflow bots.
  2. The associated issue is the issue number that is embedded in the pull request head branch.
  3. The list above will be automatically updated as the pull request's various settings match or do not match the associated issue.
  4. To manually sync the pull request to the issue, create a comment with the [run-sync] command.

    Note You must be an admin member of the organization to use this command.


  • Sync with the issue. Use this to enable or disable this pull request from syncing with its associated issue.

@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.11 milestone May 15, 2024
@CalvinWilkinson CalvinWilkinson changed the title new pr 🚧Add a function to delete assets May 15, 2024
@CalvinWilkinson CalvinWilkinson added the ✨new-feature New feature that does not exist label May 15, 2024
@CalvinWilkinson CalvinWilkinson self-assigned this May 15, 2024
@CalvinWilkinson CalvinWilkinson added high-priority High Priority preview Done while in preview labels May 15, 2024
@CalvinWilkinson CalvinWilkinson changed the title 🚧Add a function to delete assets 🚧Add new funcs to release client May 15, 2024
@CalvinWilkinson CalvinWilkinson added the 🧨breaking-changes Feature/changes contains breaking changes label May 15, 2024
@CalvinWilkinson
Copy link
Member Author

Warning

Introduced the following https://github.com/KinsonDigital/kd_clients/labels/%F0%9F%A7%A8breaking%20changes

  1. Changed the type of the uploadAssetsByReleaseName function parameter named filePaths from string | string[] to string[]
  2. Changed the type of the uploadAssetsByReleaseTag function parameter named filePaths from string | string[] to string[]

@CalvinWilkinson
Copy link
Member Author

CalvinWilkinson commented May 15, 2024

Note

The https://github.com/KinsonDigital/kd_clients/labels/%E2%9C%A8new%20feature 's below were added:

  1. Added a new function named assetExists to check if a release asset exists.
  2. Added a new function named deleteAsset to delete a single asset from a release.
  3. Added a new function named uploadAsset to upload a single asset to a release.

@CalvinWilkinson CalvinWilkinson marked this pull request as ready for review May 15, 2024 14:20
@CalvinWilkinson CalvinWilkinson enabled auto-merge (squash) May 15, 2024 14:23
@CalvinWilkinson CalvinWilkinson merged commit 707d2b5 into preview May 15, 2024
5 checks passed
@CalvinWilkinson CalvinWilkinson deleted the feature/65-add-del-asset-funcs branch May 15, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧨breaking-changes Feature/changes contains breaking changes high-priority High Priority ✨new-feature New feature that does not exist preview Done while in preview
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🚧Add new funcs to release client
2 participants