Skip to content
This repository has been archived by the owner on Nov 21, 2020. It is now read-only.

[WIP] Plug kinto storage #12

Merged
merged 21 commits into from
Mar 30, 2016
Merged

[WIP] Plug kinto storage #12

merged 21 commits into from
Mar 30, 2016

Conversation

almet
Copy link
Member

@almet almet commented Feb 20, 2016

Add the ability to save the generated form in Kinto

  • Save the form a kinto instance;
  • Redirect the user once the form has been created, display links to admin and form;
  • Create a view where users can fill in the form;
  • List all the results in a specific route;
  • Be able to configure the kinto server to use (in the config for now);
  • Separate the concerns of the form creation and the rest;
  • Fix the redirection when submitting new records;
  • Add tests;

content: _ => <h1>Page not found.</h1>
}}/>
</Route>
<div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this div?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed!

@n1k0
Copy link
Contributor

n1k0 commented Feb 20, 2016

Looks sharp!

@almet
Copy link
Member Author

almet commented Feb 20, 2016

@n1k0 I wonder what's the actual best way to do the configuration here.

I've seen that in kinto-admin there is a config/config.json file and that the client is doing a fetch of this file. I would like to avoid reading the file over HTTP at startup. Do you see any way to do this?

@n1k0
Copy link
Contributor

n1k0 commented Feb 20, 2016

I wonder what's the actual best way to do the configuration here.
I would like, if possible, to avoid having to read the file over HTTP at startup

There's a static config module for the formbuilder already, what more would you need?

@almet
Copy link
Member Author

almet commented Feb 20, 2016

I was thinking about a way to start the formbuilder with a --config option pointing to the correct json configuration (and not JS), but that's probably for another issue, I will use the existing config.js for now.

edit: I've created #13 about this.

@n1k0
Copy link
Contributor

n1k0 commented Feb 20, 2016

a way to start the formbuilder with a --config option

Remember that the formbuilder is a webpage and has no clue how it's served (and that's a feature) :)

It was starting to make a lot of different files under the same directory, it
will be easier to follow like that.
@almet
Copy link
Member Author

almet commented Mar 30, 2016

Moving forward (discussed with @n1k0).

@almet almet merged commit dd01354 into master Mar 30, 2016
@almet almet deleted the plug-kinto-storage branch March 30, 2016 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants