Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to update a collection's settings when there is an error, leads to no obvious indication without scrolling #3059

Closed
alexcottner opened this issue Nov 15, 2023 · 0 comments · Fixed by #3060
Assignees
Labels
Milestone

Comments

@alexcottner
Copy link
Contributor

Copied from bugzilla bug 1593229.

STR

Edit an existing collection's setup, by clicking the cog icon.
On a short-ish screen (so that the update button is off the page).
Do something to create an error, e.g. insert a comma to make a schema invalid.
Scroll down and click the "Update Collection" button

Expected Results

=> Indication there's an error, and what the issue is.

Actual Results

=> Nothing obvious happens.
=> Only when you scroll back up to the top of the page do you see the errors listed.

This appears to affect everything using our BaseForm component. Main plan is to create generic error handling there (assuming rjsf doesn't have something already) so we scroll to the top-most validation error when we fail validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants