Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[signoff] Make it clearer when we only show "changes since the last signature" #503

Closed
glasserc opened this issue Mar 28, 2018 · 4 comments

Comments

@glasserc
Copy link
Contributor

// Fetch the source changes made since the last signature (since=0 means everything).

Otherwise, it can just seem like there's a bug where we don't show all the records for some reason.

@leplatrem
Copy link
Contributor

leplatrem commented Mar 28, 2018

Also, we should take into account the fact that collections can be resigned (source.last_modified > preview.last_modified), if that's relevant

@leplatrem leplatrem changed the title Make it clearer when we only show "changes since the last signature" [signoff] Make it clearer when we only show "changes since the last signature" Mar 29, 2018
@leplatrem leplatrem added this to Backlog in kinto-admin UI polish Sep 20, 2018
@leplatrem
Copy link
Contributor

I can't find where this applies. Do you recall @glasserc ?

@glasserc
Copy link
Contributor Author

glasserc commented Jun 3, 2019

This might have gotten fixed by #936.

@glasserc
Copy link
Contributor Author

glasserc commented Jun 3, 2019

We can't figure out where this issue was applied. It doesn't look like we filter the records to only show those since the last signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants