Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[signoff] Show diff in the source collection (and not only after review request) #935

Closed
leplatrem opened this issue May 29, 2019 · 0 comments · Fixed by #943
Closed

[signoff] Show diff in the source collection (and not only after review request) #935

leplatrem opened this issue May 29, 2019 · 0 comments · Fixed by #943
Labels
ux
Projects
kinto-admin UI polish

Comments

@leplatrem
Copy link
Contributor

Otherwise users have no way to see what they've changed until they request a review.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1538967
@leplatrem leplatrem added the ux label May 29, 2019
@leplatrem leplatrem added this to Backlog in kinto-admin UI polish via automation May 29, 2019
@leplatrem leplatrem mentioned this issue May 30, 2019
Merged
leplatrem added a commit that referenced this issue May 31, 2019
@leplatrem
Fix #935: Show changes in source collection
f8fb492
leplatrem added a commit that referenced this issue May 31, 2019
@leplatrem
Fix #935: Show changes in source collection
925d24b
leplatrem added a commit that referenced this issue May 31, 2019
@leplatrem
Fix #935: Show changes in source collection
dfdbe10
@leplatrem leplatrem mentioned this issue May 31, 2019
Merged
@leplatrem leplatrem moved this from Backlog to In progress in kinto-admin UI polish Jun 3, 2019
kinto-admin UI polish automation moved this from In progress to Done Jun 5, 2019
leplatrem added a commit that referenced this issue Jun 5, 2019
@leplatrem
Fix #935: show diff in source collection (#943)
91bd6bc 
* Rename current list of changes to changesOnPreview

* Fetch changes on source and preview

* Fix #935: Show changes in source collection

* Refactor loading of changes for better UX

* Fetch source attributes first
* Determine if changes were made based on metadata
* Only fetch one change list based on status

Note: maybe it could make sense to show both change lists in the UI,
that's why I left both in the state. I find it more explicit, happy
to discuss...

* Move changesOnSource and changesOnPreview out of source

* Upgrade to kinto-http.js@4.7.0

* Leverage getRecordsTimestamp()

* @glasserc review

Add types comment in signoff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ux
Projects
kinto-admin UI polish
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #935: show diff in source collection Kinto/kinto-admin
1 participant
@leplatrem