-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spinners and disable forms while data is being loaded - alternate #3050
Add spinners and disable forms while data is being loaded - alternate #3050
Conversation
…ndle submit spinners, but allow other forms to override to true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beforeEach(() => {}); | ||
|
||
afterEach(() => {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope! Added them out of habit and forgot to remove them because prettier made them too small. I noticed them in the next branch and will be removing them then.
Co-authored-by: grahamalama <graham.beckley@gmail.com>
…ottner/kinto-admin into implement-spinners-cleaner
Alternate (hopefully slightly cleaner) PR compared to 3049.
The goal of this PR is to prevent users from interacting with forms while we're waiting on server responses. I think the easiest way to do that is to:
This should resolve the following open issues:
simplescreenrecorder-2023-11-01_11.41.55.mp4