Migrating action creators to Redux saga #77
Conversation
| @@ -21,7 +21,7 @@ export default class CollectionEdit extends Component { | |||
|
|
|||
| render() { | |||
| const {collection} = this.props; | |||
| const {label, schema, uiSchema, displayFields, busy} = collection; | |||
| const {schema={}, uiSchema={}, displayFields=[], label, busy} = collection; | |||
There was a problem hiding this comment.
wao, I didn't know about that syntax :) neat !
There was a problem hiding this comment.
Me neither 2 days ago :p Now I see so many places this should be used it's embarrassing.
n1k0
changed the title
|
This is now ready for, ahem, review. I'm pretty sure no one on Earth will ever want to thoroughly review this, so I'm gonna let it sit for a few hours and land it if I don't get any feedback meanwhile. Pinging @Natim @leplatrem @glasserc @almet |
|
I will have a look at it :) |
|
|
||
| let client; | ||
|
|
||
| export function setupClient({server, username, password}) { |
There was a problem hiding this comment.
I wonder if we shouldn't pass the authorization header directly to later support other authorization methods.
There was a problem hiding this comment.
yeah, but please let's iterate here :)
|
There is tests 👍 |
|
I read the code, it looks good to me. |
|
I'm landing this. |
This patch leverages redux-saga and moved the action creators logic to dedicated sagas. Actions are now just simple synchronous descriptors, and sagas handle the asynchronous request stuff, triggering actions to notify the reducers when they're processed.
That makes the codebase better organized and easier to read especially because of the use of generators.
While the diff is large and seems to add more code than before, this is mostly because we now have much more granular tests for action creators.
The patch has been deployed to gh-pages.
Todo