Add tests.

kinto_elasticsearch/command_reindex.py

@@ -41,8 +41,8 @@ def main(cli_args=None):
     try:
         indexer = registry.indexer
     except AttributeError:
-        print("kinto-elasticsearch not available.")
-        return 22
+        logger.error("kinto-elasticsearch not available.")
+        return 62
 
     bucket_id = args.bucket
     collection_id = args.collection
@@ -51,13 +51,13 @@ def main(cli_args=None):
     try:
         schema = get_index_schema(registry.storage, bucket_id, collection_id)
     except RecordNotFoundError:
-        print("No collection '%s' in bucket '%s'" % (collection_id, bucket_id))
-        return 32
+        logger.error("No collection '%s' in bucket '%s'" % (collection_id, bucket_id))
+        return 63
 
     # Give up if collection has no index mapping.
     if schema is None:
-        print("No `index:schema` attribute found in collection metadata.")
-        return 42
+        logger.error("No `index:schema` attribute found in collection metadata.")
+        return 64
 
     # XXX: Are you sure?
     recreate_index(indexer, bucket_id, collection_id, schema)

tests/config.ini

@@ -2,7 +2,14 @@
 use = egg:kinto
 kinto.userid_hmac_secret = some-secret-string
 
+kinto.storage_backend = kinto.core.storage.postgresql
+kinto.storage_url = postgres://postgres:postgres@localhost:5432/postgres
+
+kinto.permission_backend = kinto.core.permission.postgresql
+kinto.permission_url = postgres://postgres:postgres@localhost:5432/postgres
+
 kinto.includes = kinto_elasticsearch
                  kinto.plugins.flush
+
 # We need indices to be refreshed immediately for assertions.
 kinto.elasticsearch.force_refresh = true

tests/test_elasticsearch.py

@@ -40,15 +40,6 @@ def test_returns_false_if_connection_fails(self):
 
 class PostActivation(BaseWebTest, unittest.TestCase):
 
-    @classmethod
-    def get_app_settings(cls, extras=None):
-        settings = super().get_app_settings(extras)
-        settings['storage_backend'] = 'kinto.core.storage.postgresql'
-        settings['storage_url'] = 'postgres://postgres:postgres@localhost:5432/postgres'
-        settings['permission_backend'] = 'kinto.core.permission.postgresql'
-        settings['permission_url'] = settings['storage_url']
-        return settings
-
     def setUp(self):
         app = self.make_app(settings={"kinto.includes": ""})
         capabilities = app.get("/").json["capabilities"]