Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search using GET? #14

Closed
n1k0 opened this issue May 23, 2017 · 1 comment · Fixed by #22
Closed

Search using GET? #14

n1k0 opened this issue May 23, 2017 · 1 comment · Fixed by #22
Labels

Comments

@n1k0
Copy link

n1k0 commented May 23, 2017

As discussed over IRC, it's a little strange/uncommon to use POST requests to read from the server. It seems we're just porting ES' behavior here, but we may want to revisit that strategy. A GET would make more sense to me.

@n1k0 n1k0 added the question label May 23, 2017
@Natim
Copy link
Member

Natim commented May 23, 2017

I totally agree with you here.
I think ES is using POST in order to be able to provide a JSON body.
There are some URI length limitations and you cannot provide a body with GET.
While the body of the search can be quite long with ES.

That's a draw back I would be willing to take for this plugin especially if we want to be compatible with ES behavior here.

leplatrem added a commit that referenced this issue May 23, 2017
Make explicit that we send a body (fixes #14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants