Fix retry behaviour when responses are successful (fixes #129)

CHANGELOG.rst

@@ -12,6 +12,10 @@ This document describes changes between each past release.
 - Keep tracks of Backoff headers and raise an ``BackoffException`` if
   we are not waiting enough between two calls. (#53)
 
+**Bug fixes**
+
+- Fix retry behaviour when responses are successful (fixes #129)
+
 
 7.2.0 (2017-03-17)
 ==================

kinto_http/session.py

@@ -81,7 +81,10 @@ def request(self, method, endpoint, data=None, permissions=None,
                 self.backoff = None
 
             retry = retry - 1
-            if not (200 <= resp.status_code < 400):
+            if 200 <= resp.status_code < 400:
+                # Success
+                break
+            else:
                 if resp.status_code >= 500 and retry >= 0:
                     # Wait and try again.
                     # If not forced, use retry-after header and wait.

kinto_http/tests/test_session.py

@@ -173,6 +173,12 @@ def test_does_not_retry_by_default(self):
         with self.assertRaises(KintoException):
             session.request('GET', '/v1/foobar')
 
+    def test_does_not_retry_if_successful(self):
+        self.requests_mock.request.side_effect = [self.response_200,
+                                                  self.response_403]  # retry 1
+        session = Session('https://example.org', retry=1)
+        session.request('GET', '/v1/foobar')  # Not raising.
+
     def test_succeeds_on_retry(self):
         self.requests_mock.request.side_effect = [self.response_503,
                                                   self.response_200]  # retry 1