@almet review

Kinto · Feb 5, 2016 · 9f95a33 · 9f95a33
1 parent ef41e40
commit 9f95a33
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/kinto_client/batch.py b/kinto_client/batch.py
@@ -51,14 +51,15 @@ def send(self):
         result = []
         requests = self._build_requests()
         for chunk in utils.chunks(requests, self.batch_max_requests):
-            args = ('POST', self.endpoints.get('batch'))
-            kwargs = dict(payload={'requests': chunk})
+            kwargs = dict(method='POST',
+                          endpoint=self.endpoints.get('batch'),
+                          payload={'requests': chunk})
 
             retry = self.nb_retry
             while retry >= 0:
                 headers = {}
                 try:
-                    resp, headers = self.session.request(*args, **kwargs)
+                    resp, headers = self.session.request(**kwargs)
                 except KintoException as e:
                     if retry <= 0:
                         raise e

diff --git a/kinto_client/tests/test_batch.py b/kinto_client/tests/test_batch.py
@@ -24,8 +24,8 @@ def test_send_adds_data_attribute(self):
         batch.send()
 
         self.client.session.request.assert_called_with(
-            'POST',
-            self.client.endpoints.get('batch'),
+            method='POST',
+            endpoint=self.client.endpoints.get('batch'),
             payload={'requests': [{
                 'method': 'GET',
                 'path': '/foobar/baz',
@@ -40,8 +40,8 @@ def test_send_adds_permissions_attribute(self):
         batch.send()
 
         self.client.session.request.assert_called_with(
-            'POST',
-            self.client.endpoints.get('batch'),
+            method='POST',
+            endpoint=self.client.endpoints.get('batch'),
             payload={'requests': [{
                 'method': 'GET',
                 'path': '/foobar/baz',
@@ -55,8 +55,8 @@ def test_send_adds_headers_if_specified(self):
         batch.send()
 
         self.client.session.request.assert_called_with(
-            'POST',
-            self.client.endpoints.get('batch'),
+            method='POST',
+            endpoint=self.client.endpoints.get('batch'),
             payload={'requests': [{
                 'method': 'GET',
                 'path': '/foobar/baz',

diff --git a/kinto_client/tests/test_client.py b/kinto_client/tests/test_client.py
@@ -22,8 +22,8 @@ def test_context_manager_works_as_expected(self):
             batch.create_record(id=5678, data={'bar': 'baz'})
 
         self.session.request.assert_called_with(
-            'POST',
-            '/batch',
+            method='POST',
+            endpoint='/batch',
             payload={'requests': [
                 {'body': {'data': {'foo': 'bar'}},
                  'path': '/buckets/mozilla/collections/test/records/1234',