Introduce PatchType #158
Merged
Introduce PatchType #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea, go for it :) 👍 |
Merged
Use this to distinguish different patch types, but only on patch_record. Other patch_methods can come later if the technique seems sane.
This makes it easier to write these kinds of PATCH methods.
This is analogous to patch_record, except that even if no ID is present, we can still sometimes succeed because we have a _bucket_name attribute.
Also, add a test, since one isn't present.
This argument in update_bucket, update_group, update_collection, and update_record only existed to support the patch methods, as far as I can tell, since it's completely untested. Since it no longer makes sense to pass anything but ``PUT`` here, take it out.
Also, wrong patches should be TypeError, not ValueError.
leplatrem
reviewed
Aug 17, 2017
glasserc
commented
Aug 17, 2017
README.rst
Outdated
|
|
||
| # It is also possible to manipulate bucket permissions (see later) | ||
| client.patch_bucket(id='payments', permissions={}) | ||
| client.patch_bucket(id='payments', data=BasicPatch({'status': 'updated'}), permissions={}) |
There was a problem hiding this comment.
I wasn't sure how to update this, but the given example wouldn't work with the new code. There's no tests for this kind of behavior either. If we intend for it to work even when you don't pass data at all, we should add tests for it.
There was a problem hiding this comment.
I agree, if there is no test then it does not exist.
However, I believe this is a relevant use-case.
You can remove this from the README and open an issue to support it.
|
I just realized that this only supports patching |
While we're here, make the pytest.raises assertions a little stricter.
Permissions have to be part of a patch_type because they are covered by the same Content-Type. This also means we can handle updating just permissions without updating the data (fixes #161).
This verifies that it actually works with the server!
leplatrem
approved these changes
Aug 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept to demonstrate my opinion on the preferred way to address #125. I only updated patch_record so far, but adding others should be straightforward.