Replication #26
Merged
Replication #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently missing: - Caching of the last_modified stamp for the collection; - Support for BATCHing of more records than the max per batch;
|
r? @leplatrem |
| return self._paginated(next_page, records, | ||
| with_headers=with_headers, | ||
| if_none_match=if_none_match) | ||
| if with_headers is True: |
There was a problem hiding this comment.
Not really sure about this one: it's a way to return the headers, as they can be useful sometimes.
There was a problem hiding this comment.
hum, yes but that is strange to alter the return type based on input parameter
There was a problem hiding this comment.
I removed it, it seems not to be used anymore in the kinto-updater.
|
This PR introduces a regression in the kinto-updater. I'm investigating which tests are missing here :) |
| request = { | ||
| 'method': method.upper(), | ||
| 'path': url} | ||
| 'path': url.replace('v1/', '')} |
There was a problem hiding this comment.
do you have a test somewhere for this one?
|
I like it globally, except the |
Otherwise the replication doesn't work properly and new last_modified values are created for each record, whereas we need to have the same one between servers.
It's not used anymore in the clients and makes the API a bit weird by returning a different thing (not the same number of arguments) depending on parameters.
- Better wording for the replication function. - Add default values for exceptions.response and exception.request - Add tests for utils.quote() - Improve readability of some function.
|
r+ ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's now ready for review!