Do not send body in GET requests #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
reviewed
Apr 5, 2023
| if "files" in kwargs: | ||
| kwargs.setdefault("data", payload) | ||
|
|
||
| else: | ||
| kwargs.setdefault("data", utils.json_dumps(payload)) | ||
| kwargs["headers"].setdefault("Content-Type", "application/json") |
There was a problem hiding this comment.
Suggested change
| kwargs["headers"].setdefault("Content-Type", "application/json") | |
| kwargs["headers"].setdefault("Content-Type", "application/json") | |
| if method.lower() in ("get", "head") and kwargs.get("data"): | |
| raise KintoException("GET requests are not allowed to have a body!") |
Because in the bug we found, data is not specified, but we have payload = payload or {} and kwargs.setdefault("data", payload)
By moving it down here, we cover all cases.
| with pytest.raises(KintoException) as err: | ||
| session.request("GET", "/", data={"foo": "bar"}) | ||
|
|
||
|
|
There was a problem hiding this comment.
You can also add a test that fails with current master, which is:
Suggested change
| def test_get_does_not_send_body(session_setup: Tuple[MagicMock, Session]): | |
| requests_mock, _ = session_setup | |
| response = get_200() | |
| requests_mock.request.return_value = response | |
| session = Session("https://example.org", timeout=4) | |
| assert session.auth is None | |
| session.request("GET", "/test") | |
| requests_mock.request.assert_called_with( | |
| "GET", | |
| "https://example.org/test", | |
| timeout=4, | |
| headers=requests_mock.request.headers, | |
| ) | |
leplatrem
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.