kinto lowercase and slugify collection_name and bucket_name #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe we should use slugify only if the given bucket_name and collection_name doesn't fit the kinto ID format. |
|
r? @almet |
|
r+ |
|
|
||
| def slugify(value): | ||
| """Normalizes string, converts to lowercase, removes non-alpha characters | ||
| and converts spaces to hyphens. | ||
| """ | ||
| value = unidecode(six.text_type(value)) | ||
| value = six.text_type(value) | ||
| # Do not lowercase already valid value. |
There was a problem hiding this comment.
Do you mean: "do not slugify existing value"?
There was a problem hiding this comment.
All the value are existing :) I mean doesn't distort values that are valid ids.
There was a problem hiding this comment.
Then you can update this comment :) "Do not slugify valid values"
almet
added a commit
that referenced
this pull request
Jan 18, 2016
kinto lowercase and slugify collection_name and bucket_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to create a
/buckets/loopClient/collections/en-UScollection with kinto.py will create ``/buckets/loopclient/collections/en-us`