Find dn before login user #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
reviewed
Nov 23, 2016
| @@ -25,13 +25,39 @@ def user_checker(username, password, request): | |||
| cache = request.registry.cache | |||
| cache_result = cache.get(cache_key) | |||
|
|
|||
| ldap_fqn = settings['ldap.fqn'] | |||
| bind_dn = settings.get('ldap.bind_dn') | |||
| bind_password = settings.get('bind.password') | |||
There was a problem hiding this comment.
does not match what's in the README
leplatrem
approved these changes
Nov 23, 2016
| # filter provided in the ldap.fqn_filters directive with the | ||
| # username passed by the HTTP client. | ||
| base_dn = settings['ldap.base_dn'] | ||
| filters = settings['ldap.filters'].format(mail=username) |
There was a problem hiding this comment.
note: this will fail if {mail} is not in the filters setting. Should we raise a ConfigurationError in case if it's not?
There was a problem hiding this comment.
That's a nice way to handle this case, I will do that thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @leplatrem