Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

Fixed Issue #2: Add the ldap capability on the hello page #4

Merged
merged 1 commit into from
Jun 30, 2016
Merged

Fixed Issue #2: Add the ldap capability on the hello page #4

merged 1 commit into from
Jun 30, 2016

Conversation

lavish205
Copy link
Member

Fixes #2

@lavish205
Copy link
Member Author

I'm unable to write test case as there was no BaseWebTest class to inherit from which I can get self.app instance.

@Natim
Copy link
Member

Natim commented Jun 30, 2016

You can probably add some code to create that self.app variable.

Looks at how we did it here: https://github.com/mozilla-services/kinto-fxa/blob/master/kinto_fxa/tests/test_views.py#L27-L82

@lavish205 lavish205 changed the title [WIP] Fixed Issue #2: Add the ldap capability on the hello page Fixed Issue #2: Add the ldap capability on the hello page Jun 30, 2016
@Natim
Copy link
Member

Natim commented Jun 30, 2016

Great 👍

@Natim Natim merged commit fb44d32 into Kinto:master Jun 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lavish205 @Natim