Merge pull request #79 from mozilla-services/deprecation-headers

Fixes #69 - Handle deprecation header.
Kinto · Jul 17, 2015 · 5b0d3d8 · 5b0d3d8
2 parents 95cd04a + c6b5d77
commit 5b0d3d8
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 1 deletion.
diff --git a/src/http.js b/src/http.js
@@ -7,6 +7,18 @@ export const DEFAULT_REQUEST_HEADERS = {
   "Content-Type": "application/json",
 };
 
+function checkForDeprecationHeader(headers) {
+  const alertHeader = headers.get("Alert");
+  if (!alertHeader)
+    return;
+  try {
+    const {message, url} = JSON.parse(alertHeader);
+    console.warn(message, url);
+  } catch(err) {
+    console.warn("Unable to parse Alert header message", alertHeader);
+  }
+}
+
 /**
  * Performs an HTTP request to the Kinto server. Resolves with an objet
  * containing the following properties:
@@ -32,6 +44,7 @@ export default function request(url, options={headers:{}}) {
       const contentLength = headers.get("Content-Length");
       if (!contentLength || contentLength == 0)
         return null;
+      checkForDeprecationHeader(headers);
       return res.json();
     })
     .catch(err => {

diff --git a/test/http_test.js b/test/http_test.js
@@ -101,7 +101,8 @@ describe("request()", () => {
         status: 200,
         headers: {
           get(name) {
-            return "fake";
+            if (name !== "Alert")
+              return "fake";
           }
         },
         json() {
@@ -135,4 +136,39 @@ describe("request()", () => {
         .should.be.rejectedWith(Error, /HTTP 400; Invalid request parameter: data is missing/);
     });
   });
+
+  describe("Deprecation header", () => {
+    beforeEach(() => {
+      sandbox.stub(console, "warn");
+    });
+
+    it("should handle deprecation header", () => {
+      const eolObject = {
+        code:    "soft-eol",
+        url:     "http://eos-url",
+        message: "This service will soon be decommissioned",
+      };
+      sandbox.stub(root, "fetch").returns(
+        fakeServerResponse(200, {}, {Alert: JSON.stringify(eolObject)}));
+
+      return request("/")
+        .then(_ => {
+          sinon.assert.calledOnce(console.warn);
+          sinon.assert.calledWithExactly(
+            console.warn, eolObject.message, eolObject.url);
+        });
+    });
+
+    it("should handle deprecation header parse error", () => {
+      sandbox.stub(root, "fetch").returns(
+        fakeServerResponse(200, {}, {Alert: "dafuq"}));
+
+      return request("/")
+        .then(_ => {
+          sinon.assert.calledOnce(console.warn);
+          sinon.assert.calledWithExactly(
+            console.warn, "Unable to parse Alert header message", "dafuq");
+        });
+    });
+  });
 });