Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fake-indexeddb to version 2.0.2 🚀 #690

Closed
wants to merge 1 commit into from

Conversation

greenkeeperio-bot
Copy link
Contributor

🚨🔥⚠️ Action required: Switch to the new Greenkeeper now! 🚨🔥⚠️
This version of Greenkeper will be shutdown on May 31st.
With Integrations first-class bot support landed on GitHub and we’ve rewritten Greenkeeper to take full advantage of it. Simpler setup, fewer pull-requests, faster than ever.


Hello lovely humans,

fake-indexeddb just published its new version 2.0.2.

State Update 🚀
Dependency fake-indexeddb
New version 2.0.2
Type devDependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of fake-indexeddb.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


GitHub Release

  • Include core-js by default to make it work more easily in old environments like PhantomJS

The new version differs by 82 commits .

  • 9f5963a 2.0.2
  • e048de1 Include core-js by default to make it work more easily in old environments like PhantomJS - fixes #19
  • b469b75 2.0.1
  • 9fc09f2 Minor updates to README
  • 6fbd7ae Release date
  • 8547e57 2.0.0
  • 2acbd16 Fix backwards compatibility with 1.x
  • bc3daba README
  • aaae590 Updating documentation, in preparation for v2.0
  • 1dc962f Use a Set for FDBTransaction._scope
  • 723ee80 Backwards compatibility
  • 4b86e1c Update stuff for publishing to npm
  • eab83f6 TODO
  • 7461b6f Hackily "fix" tests for Node 4, because some of the converted tests just will not run
  • 8eacecb Node 4 plan

There are 82 commits in total. See the full diff.

@glasserc
Copy link
Contributor

glasserc commented May 2, 2017

Despite the Greenkeeper message, the tests failed on Travis-CI. Running them locally, they seem to fail on my machine too, and intermittently (which is the worst way to fail). I hesitate to blame fake-indexeddb, especially because I know we're at least doing one questionable thing in kinto.js (https://github.com/Kinto/kinto.js/blob/master/test/collection_test.js#L1671). On the other hand, they just rewrote the project in TypeScript, and now support IndexedDB API v2.0, so who knows what to expect.

Even if I limit to just one test (e.g. by putting only on https://github.com/Kinto/kinto.js/blob/master/test/collection_test.js#L1492), tests still seem to fail about one time in four or so. I'm not really sure what to do here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants