Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to rotate hmac secret ? #691

Closed
leplatrem opened this issue Jun 28, 2016 · 5 comments
Closed

How to rotate hmac secret ? #691

leplatrem opened this issue Jun 28, 2016 · 5 comments
Labels

Comments

@leplatrem
Copy link
Contributor

Currently, with the default BasicAuth authentication policy, a unique «userid» is generated from the tuple user:pass using the hmac secret in the settings.

If the hmac secret changes, the resulting «userid» will differ. Although technically the existing data won't disappear, the user won't be able to access them!

We have to identify every bit that relies on the hmac secret and make sure that we provide a mecanism to change it without consequence for the users.

Regarding BasicAuth, we could just list this among the limitations of this authentication policy.

Related #297

@Natim
Copy link
Member

Natim commented Jun 28, 2016

Note that even for non Basic Auth backend we are still using the hmac secret to generate the bucket ID of a given authenticated user.

@leplatrem
Copy link
Contributor Author

generate the bucket ID of a given authenticated user

Oh. Well this is restricted to the default_bucket plugin...

@Natim
Copy link
Member

Natim commented Jun 28, 2016

Yes the bucket ID generated is the name of the user default bucket

@Natim
Copy link
Member

Natim commented Nov 22, 2016

After thinking this through the answer to this question is that we shouldn't need to rotate this secret.

This means that you should avoid using the default BasicAuth policy in production.
You should use #795 or #933 or any other authentication mecanism.

@leplatrem
Copy link
Contributor Author

Agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants