Filtering history with ?collection_id=0 returns an empty list

[leplatrem]

• Create a collection whose name is 0
• Filter the history with ?collection_id=0
• Instead of obtaining the history entry, the obtained list is empty

[gabisurita]

This may not only be related to history entries.

If we create the collections with ids 0, 1 and string, the behavior is different when selecting via the id parameter.

$ echo '{"data": {"description": "Collection Zero"}}' | http PUT https://kinto.dev.mozaws.net/v1/buckets/default/collections/0 -v --auth 'hey:you'

$ echo '{"data": {"description": "Collection One"}}' | http PUT https://kinto.dev.mozaws.net/v1/buckets/default/collections/1 -v --auth 'hey:you'

$ echo '{"data": {"description": "Collection String"}}' | http PUT https://kinto.dev.mozaws.net/v1/buckets/default/collections/string -v --auth 'hey:you'

$ http GET https://kinto.dev.mozaws.net/v1/buckets/default/collections -v --auth 'hey:you'

{
    "data": [
        {
            "description": "Collection String", 
            "id": "string", 
            "last_modified": 1475731844316
        }, 
        {
            "description": "Collection One", 
            "id": "1", 
            "last_modified": 1475731818775
        }, 
        {
            "description": "Collection Zero", 
            "id": "0", 
            "last_modified": 1475731794491
        }
    ]
}

$ http GET https://kinto.dev.mozaws.net/v1/buckets/default/collections?id=string -v --auth 'hey:you'

{
    "data": [
        {
            "description": "Collection String", 
            "id": "string", 
            "last_modified": 1475731844316
        }
    ]
}

$ http GET https://kinto.dev.mozaws.net/v1/buckets/default/collections?id=0 -v --auth 'hey:you'

{
    "data": []
}

$ http GET https://kinto.dev.mozaws.net/v1/buckets/default/collections?id=1 -v --auth 'hey:you'

{
    "data": []
}

[leplatrem]

Nice catch @gabisurita !

The problem comes indeed that we interpolate the field value as a native python value (which is integer) and then compare it with a string (id).

I remember also that we don't want to compare with string if the store value is an integer.

The fix might not be so easy actually, since we don't always have the schema of the data.

We could maybe filter with something like field IN ("0", 0) but I find it very ugly...