Fix IntegrityError for 5.3.X branch #1058
Conversation
| with self.client.connect() as conn: | ||
| conn.execute(query, dict(key=self.prefix + key, | ||
| value=value, ttl=ttl)) | ||
| server_version = conn.connection().dialect.server_version_info |
There was a problem hiding this comment.
nitpick: here https://github.com/zzzeek/sqlalchemy/blob/bc4a96836d5bfb911da26f7e77119f3a7b356f2e/lib/sqlalchemy/testing/exclusions.py#L384 they use getattr so maybe we should use it too and compare version >= (9, 5)
There was a problem hiding this comment.
I don't think we need to use getattr there because we are always using the pgdialect that will always define it.
|
Quick note on maintainance: I'd rather continue to submit patches to the |
|
I agree with you generally but for this specific case the patch are different between the master 6.X and the 5.X branch |
Gotcha, but maybe we can handle the situation in the content of the commit that backports the change? (not sure what's best, let's see next time...). |
Fixes #1055