Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix requests output when running with make serve (fixes #1242) #1260

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Fix requests output when running with make serve (fixes #1242) #1260

merged 1 commit into from
Jun 9, 2017

Conversation

leplatrem
Copy link
Contributor

Fixes #1242

@leplatrem leplatrem requested a review from Natim June 8, 2017 09:35
glasserc
glasserc approved these changes Jun 8, 2017
View reviewed changes
Copy link
Contributor

@glasserc glasserc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do we want to enforce a version of Pyramid that has the fix included?

@leplatrem
Copy link
Contributor Author

It's already the case (pyramid > 1.8) :)

@leplatrem leplatrem merged commit 7b19314 into master Jun 9, 2017
@leplatrem leplatrem deleted the 1242-fix-make-serve-output branch June 9, 2017 08:36
Natim
Natim reviewed Jun 12, 2017
View reviewed changes
Copy link
Member

@Natim Natim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Natim Natim Natim left review comments

@glasserc glasserc glasserc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leplatrem @glasserc @Natim