Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsonschema errors #1268

Merged
merged 5 commits into from
Jun 13, 2017
Merged

Fix jsonschema errors #1268

merged 5 commits into from
Jun 13, 2017

Conversation

glasserc
Copy link
Contributor

@glasserc glasserc commented Jun 13, 2017

#1245 changed the format of the jsonschema error messages. It isn't clear exactly why; the commit message just says "Simplify and fix coverage". https://github.com/Kinto/kinto-attachment has a test that started failing because it relies on the format of the error message. Restore it.

  • (n/a) Add documentation.
  • Add tests.
  • Add a changelog entry.
  • (n/a) Add your name in the contributors file.
  • (n/a) If you changed the HTTP API, update the API_VERSION constant and add an API changelog entry in the docs

r? @leplatrem

@leplatrem
Copy link
Contributor

It isn't clear exactly why; the commit message just says "Simplify and fix coverage"

There was a piece of code that was never executed. Since no test was failing without it, I just removed it :)

@leplatrem
Copy link
Contributor

Since #1245 was released, we'll need a changelog entry

@glasserc glasserc merged commit 58508c6 into Kinto:master Jun 13, 2017
@glasserc glasserc deleted the fix-jsonschema-errors branch June 13, 2017 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants