Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from setup.cfg/setup.py to pyproject.toml #3359

Merged
merged 9 commits into from
Jan 25, 2024
Merged

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Jan 24, 2024

Repo modernization!

  • Merge Get rid of tox #3357
  • Switch from setup.cfg/setup.py to pyproject.toml
  • Use requirements.in to build the constraints file. This is messy, and would probably lead us to a wrapper like Poetry, in order to have a proper lock file. Because pip does not support hashes in editable mode, and pip-compile does not pick extra dependencies from pyproject.toml, they therefore have to be duplicated in a requirements.in file.
  • Update release docs. One-click release! But I left the 3 steps that consist in checking that everything is ready and that everything was published correctly
  • Check that entry points still work
  • Fix Docker container build (see Run functional tests on freshly built container #3367)

@leplatrem leplatrem marked this pull request as draft January 24, 2024 10:10
@leplatrem leplatrem force-pushed the switch-pyproject branch 4 times, most recently from 474dce9 to 8c23eb1 Compare January 25, 2024 10:23
@leplatrem leplatrem marked this pull request as ready for review January 25, 2024 10:30
@leplatrem
Copy link
Contributor Author

I noticed the docker image build is broken in this PR, I'll open a separate PR to run the functional tests against a freshly docker image

docs/community.rst Outdated Show resolved Hide resolved
@@ -0,0 +1,40 @@
# main dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, what is the difference between these dependencies and those listed in pyproject.toml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requirements.in is just the "source" of our constraints file.

And the dependencies in pyproject.toml are the final package dependencies (when installed from pip for example).

I will open an issue about that, because I'm not happy about a single requirements.txt as a constraints file, for both our main and our extra dependencies.

Co-authored-by: grahamalama <gbeckley@mozilla.com>
@leplatrem leplatrem merged commit 0028db3 into main Jan 25, 2024
15 checks passed
@leplatrem leplatrem deleted the switch-pyproject branch January 25, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants